Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Personalized resource limits: remove services limitations table 🗃️ #4428

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 27, 2023

What do these changes do?

  • remove unused database table

Related issue/s

How to test

DevOps Checklist

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #4428 (8f0d57e) into master (bab7026) will increase coverage by 2.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4428     +/-   ##
========================================
+ Coverage    83.8%   86.0%   +2.2%     
========================================
  Files        1000     859    -141     
  Lines       42817   37834   -4983     
  Branches     1026     470    -556     
========================================
- Hits        35893   32570   -3323     
+ Misses       6702    5148   -1554     
+ Partials      222     116    -106     
Flag Coverage Δ
integrationtests 67.6% <ø> (?)
unittests 83.3% <ø> (-0.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 228 files with indirect coverage changes

@sanderegg sanderegg force-pushed the personalized-resource-limits/remove-services-limitations-table branch 2 times, most recently from 1508a88 to 99bcc1c Compare June 29, 2023 06:17
@sanderegg sanderegg marked this pull request as ready for review June 29, 2023 06:18
@sanderegg sanderegg force-pushed the personalized-resource-limits/remove-services-limitations-table branch from 64c5ac7 to 8edbae7 Compare June 29, 2023 06:20
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jun 29, 2023

Code Climate has analyzed commit 8f0d57e and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg sanderegg merged commit c51bb02 into ITISFoundation:master Jun 29, 2023
@sanderegg sanderegg deleted the personalized-resource-limits/remove-services-limitations-table branch June 29, 2023 08:20
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 12, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants