Skip to content

Skip broken acoth tests #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2025
Merged

Skip broken acoth tests #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a60e93
Unbreak fixed acoth tests
mtfishman Oct 1, 2025
7a9f329
Bump version
mtfishman Oct 1, 2025
cbe5890
Skip broken acoth test
mtfishman Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
.vscode/
Manifest.toml
benchmark/*.json
dev/
docs/LocalPreferences.toml
docs/Manifest.toml
docs/build/
docs/src/index.md
examples/LocalPreferences.toml
test/LocalPreferences.toml
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "BlockSparseArrays"
uuid = "2c9a651f-6452-4ace-a6ac-809f4280fbb4"
authors = ["ITensor developers <support@itensor.org> and contributors"]
version = "0.10.5"
version = "0.10.6"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
13 changes: 5 additions & 8 deletions test/test_factorizations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ using MatrixAlgebraKit:
trunctol
using Random: Random
using StableRNGs: StableRNG
using Test: @inferred, @test, @test_broken, @test_throws, @testset
using Test: @inferred, @test, @test_throws, @testset

@testset "Matrix functions (T=$elt)" for elt in (Float32, Float64, ComplexF64)
for matrixt in (Matrix, AbstractMatrix)
Expand All @@ -55,13 +55,10 @@ using Test: @inferred, @test, @test_broken, @test_throws, @testset
for f in MATRIX_FUNCTIONS_LOW_ACCURACY
@eval begin
fa = $f($a)
if !Sys.isapple() && ($elt <: Real)
# `acoth` appears to be broken on this matrix on Windows and Ubuntu
# for real matrices.
@test_broken Matrix(fa) ≈ $f(Matrix($a)) rtol = √eps(real($elt))
else
@test Matrix(fa) ≈ $f(Matrix($a)) rtol = √eps(real($elt))
end
# `acoth` appears to be broken on this matrix on Windows and Ubuntu
# for real matrices.
skip = !Sys.isapple() && ($elt <: Real)
@test Matrix(fa) ≈ $f(Matrix($a)) rtol = √eps(real($elt)) skip = skip
@test fa isa BlockSparseMatrix
@test issetequal(eachblockstoredindex(fa), [Block(1, 1), Block(2, 2)])
end
Expand Down
Loading