Skip to content

Fix a bug in blocktype #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 7, 2025
Merged

Fix a bug in blocktype #40

merged 7 commits into from
Feb 7, 2025

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Feb 7, 2025

This fixes an incorrect definition of blocktype for non-blocked arrays. Now, in general it will return a SubArray wrapping the original array, because that is the result of eltype(blocks(a)) by convention in BlockArrays.jl. I've also added more systematic tests for blocktype and blockstype, and added some missing definitions for BlockArrays.BlockArray.

@mtfishman mtfishman requested review from ogauthe and lkdvos February 7, 2025 16:29
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.31%. Comparing base (88aa06f) to head (767d82b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ksparsearrayinterface/blocksparsearrayinterface.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   73.93%   74.31%   +0.38%     
==========================================
  Files          30       30              
  Lines        1055     1059       +4     
==========================================
+ Hits          780      787       +7     
+ Misses        275      272       -3     
Flag Coverage Δ
docs 26.00% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman merged commit f7e162f into main Feb 7, 2025
12 checks passed
@mtfishman mtfishman deleted the fix_blocktype branch February 7, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants