Support for eigen of dual operator #1670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
reviewed
Sep 18, 2025
Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>
|
@mtfishman does this PR look ok to you now that tests are passing? (Except Jenkins which I'm not sure about.) |
|
Looks good to me. Test failures are unrelated, it may be related to a cuTENSOR issue discussed here: JuliaGPU/CUDA.jl#2881. If I'm following that thread correctly, an explanation might be that our Jenkins setup is running on a GPU that is not supported by the latest versions of cuTENSOR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
eigenfunction to handle fermionic matrices or operators which have an In,Out index ordering (e.g. "dual operators") such as density matrices or density-matrix-like messages. It also includes new tests.Specifically, in cases where the tensor components are a Hermitian positive semidefinite (HPSD) matrix, then we want eigen to return a diagonal "D" ITensor which has non-negative entries when its indices are in the In, Out ordering.
Commits: