Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NVME disk counter + "Best_Wins" logic fix #540

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

adn77
Copy link

@adn77 adn77 commented Nov 6, 2023

We noticed that disk performance counters did not get into InfluxDB when using NVMe disks.
This PR fixes this issue.

Copy link

cla-bot bot commented Nov 6, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @adn77

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@adn77
Copy link
Author

adn77 commented Nov 6, 2023

CLA has now been signed.

@bobapple
Copy link
Member

bobapple commented Nov 6, 2023

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Nov 6, 2023
@adn77 adn77 changed the title Fix NVME disk counter Fix NVME disk counter + "Best_Wins" logic fix Mar 25, 2024
@adn77
Copy link
Author

adn77 commented Mar 25, 2024

Sorry for pushing this in a single PR, there was a logical error in the evaluation of best_wins (absolute or percentage).
The best_wins setting was only taken into account if BOTH values were already below a not-normal state.

This should be an or condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants