PHP 8.2 Support #5003
Closed
PHP 8.2 Support #5003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAINCER
force-pushed
the
PHP8.2-Support
branch
4 times, most recently
from
ddadfae
to
6b6ebd8
Compare
TAINCER
force-pushed
the
PHP8.2-vendor-update
branch
from
d52d8e3
to
4b42b4f
Compare
TAINCER
changed the base branch from
PHP8.2-vendor-update
to
move-vendor-packages-to-thirdparty
TAINCER
force-pushed
the
move-vendor-packages-to-thirdparty
branch
from
7426033
to
2d151e6
Compare
andypost
reviewed
Apr 15, 2023
| @@ -193,7 +193,7 @@ public function visitColor($c) | |||
| { | |||
| if ($this->definingVariable !== false) { | |||
| // Make sure that all less tree colors do have a proper name | |||
| $c->name = $this->variableOrigin->name; | |||
| // $c->name = $this->variableOrigin->name; | |||
There was a problem hiding this comment.
it could be $c->name = $this->variableOrigin?->name; as variableOrigin could be null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on