Github Actions: Add PhpStan #5040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
add-phpstan
branch
7 times, most recently
from
0c9b1fb
to
440afe3
Compare
sukhwinder33445
changed the base branch from
master
to
move-vendor-packages-to-thirdparty
sukhwinder33445
force-pushed
the
add-phpstan
branch
3 times, most recently
from
9e54a2c
to
4e9af9a
Compare
sukhwinder33445
changed the base branch from
move-vendor-packages-to-thirdparty
to
master
sukhwinder33445
force-pushed
the
add-phpstan
branch
16 times, most recently
from
ced50a6
to
a0dda11
Compare
- $featureStatus is an associative array
Use of dynamic property is deprecated since PHP 8.2
nilmerg
requested changes
Aug 23, 2023
- Remove already default flags in `max` level - Don't ingnore Zend_* errors explicitly (added to baseline)
- ldap_connect() returns `LDAP\Connection` in php >= 81
sukhwinder33445
force-pushed
the
add-phpstan
branch
2 times, most recently
from
b802ce8
to
2818757
Compare
nilmerg
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by: #5061
closes #5052, #4920, #5003