Skip to content

Changes the default for the userinfo_request_method to GET #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2019
Merged

Changes the default for the userinfo_request_method to GET #204

merged 2 commits into from
Mar 20, 2019

Conversation

skanct
Copy link
Contributor

@skanct skanct commented Feb 19, 2019

According to the OpenID Connect Core specification 1 the
recommendation is to use HTTP GET

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@skanct skanct force-pushed the ck_default_userinfo_request_method branch from 8dc1c6f to 2107d88 Compare February 19, 2019 05:07
@skanct
Changes the default for the userinfo_request_method to GET
579ea73 
According to the OpenID Connect Core specification [1] the
recommendation is to use HTTP GET

[1]: https://openid.net/specs/openid-connect-core-1_0.html#UserInfoRequest
@skanct skanct force-pushed the ck_default_userinfo_request_method branch from 6f1f970 to 579ea73 Compare February 19, 2019 05:13
@c00kiemon5ter c00kiemon5ter merged commit 2d03a86 into IdentityPython:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skanct @c00kiemon5ter