fix: OpenIDConnectFrontend: check for empty db_uri #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With IdentityPython/pyop#44 merged, OpenIDConnectFrontend init fails when
db_uri
is not set, asStorageBase.type
now throws aValueError
for db_uri values that do not match one of the recognised storage types (including whendb_uri
isNone
).Fix this by guarding the
StorageBase.type
with a pythonic test whetherdb_uri
was provided.Same test already guards
StorageBase.from_uri
, add it also to theStorageBase.type
call made to determineself.stateless
.PS: This worked before IdentityPython/pyop#44 was merged because
StorageBase.type
used to return theValueError
object, which evaluated as not matching string"stateless"
. I also thought about changingStorageBase.type
to returnNone
fordb_uri
of valueNone
, but I think it's cleaner to handle it this way and keep theStorageBase.type
contract clear: Only valid values allowed.All Submissions: