enable defaults for custom attribute release using '' or 'default' key #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def get_dict_defaults(d, *keys): | ||
| for key in keys: | ||
| d = d.get(key, d.get("", d.get("default", {}))) | ||
| return d |
There was a problem hiding this comment.
Am I understanding correctly that you want to accomplish this in other words?
def get_dict_defaults(d, *keys):
for key in keys:
if key in d:
return d[key]
elif '' in d or 'default' in d:
return d.get('', d.get('default'))
return dict()There was a problem hiding this comment.
No. I want to traverse the entire length of the "key chain" finding the most specific branch.
There was a problem hiding this comment.
Basically this is the _config function I'm using in my two other PRs for attribute authz and attribute generation. Its a pattern for config that I think @skoranda uses too in places - esp when you need to override behaviour specified by metadata on a per-Idp, per-sp+idp or globally
There was a problem hiding this comment.
Ok, I get it, you want to reuse d and the keys are in hierarchical order.
This was referenced May 30, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also contains a small utility function that I will use to refactor some of my other pull requests later. There are tests covering this already so it should be safe as long as the tests work.