Don't parse html with xml parser #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when using a custom template, we would parse the html given by pysaml2 with an xml parser to get the request xml. This broke when the SSO url had an & in it though, which was fixed by #41 ... however, other characters can cause similar xml parsing errors. The real issue is that we are using an xml parser for generated html, which could change to be invalid xml with any pysaml2 update.
To avoid this, I've redone the logic so that in the case of a http-post binding with a custom template, instead of asking pysaml2 for the full html we only ask for the request xml and utilize. This removes the need for any xml parsing there at all.