enable -Wall option when supported #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes some warnings that existed. The only tricky one was to do with g_autoptr. I'm not sure why, but I had to hoist and initialize this further up the scope to stop GCC complaining about it being potentially uninitialized in _GLIB_AUTOPTR_CLEAR_FUNC_NAME.
aperezdc
approved these changes
Jul 23, 2019
aperezdc
added
the
merge:cog-0.3
|
Also merged to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes some warnings that existed. The only tricky one was to
do with g_autoptr. I'm not sure why, but I had to hoist and initialize
this further up the scope to stop GCC complaining about it being
potentially uninitialized in _GLIB_AUTOPTR_CLEAR_FUNC_NAME.