Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install a libWPEBackend-default.so symlink with fdo (#11) #12

Closed
wants to merge 1 commit into from

Conversation

clopez
Copy link
Contributor

@clopez clopez commented May 15, 2018

  • When building with fdo support (-DCOG_PLATFORM_FDO=ON) create
    and install a libWPEBackend-default.so symlink pointing to
    libWPEBackend-fdo-0.1.so.0.

  • Also default to platform fdo is no other one is specified via
    command line argument.

 * When building with fdo support (-DCOG_PLATFORM_FDO=ON) create
   and install a libWPEBackend-default.so symlink pointing to
   libWPEBackend-fdo-0.1.so.0.

 * Also default to platform fdo is no other one is specified via
   command line argument.
@clopez clopez requested a review from aperezdc May 15, 2018 18:22
@zdobersek
Copy link
Contributor

I would propose creating libWPEBackend-cog.so and installing the libWPEBackend-default.so link that links to that libWPEBackend-cog.so library.

Upon libWPEBackend-cog.so being loaded or queried for the first interface implementation via _wpe_loader_interface, the implementation would go out and search for the appropriate libWPEBackend library (e.g. libWPEBackend-fdo.so in case of COG_PLATFORM_FDO being enabled) and then load symbols from there.

@aperezdc
Copy link
Member

aperezdc commented Jun 21, 2018

An alternative that I like better is what @carlosgcampos has implemented in WebKit#186841 and WebPlatformForEmbedded/libwpe#18 — that is, adding API to set the path to the WPE backend library, and passing it down to WPEWebProcess.

@carlosgcampos
Copy link
Contributor

Yes, please, do not install default symlink, that would make cog incompatible with all other wpe browsers using the symlink.

@aperezdc
Copy link
Member

We'll eventually have API to configure which WPE backend implementation to use, so let's not merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants