-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Fix CMake (v3.16) cannot create ALIAS target "Wpe::FDO" error #487
Merged
aperezdc
merged 1 commit into
cog-0.14
from
psaavedra/cog-0.14_fix_build_with_cmake_3_22
Sep 6, 2022
Merged
cmake: Fix CMake (v3.16) cannot create ALIAS target "Wpe::FDO" error #487
aperezdc
merged 1 commit into
cog-0.14
from
psaavedra/cog-0.14_fix_build_with_cmake_3_22
Sep 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... because target "PkgConfig::WpeFDO" is imported but not globally visible in cmake/FindWpeFDO.cmake. Notice that this issue is not reproducible in CMake v3.22. CMake doc [1][2] says: "The scope of the definition of an IMPORTED target is the directory where it was defined. It may be accessed and used from subdirectories, but not from parent directories or sibling directories. The scope is similar to the scope of a cmake variable. It is also possible to define a GLOBAL IMPORTED target which is accessible globally in the buildsystem." [1] 3.16: https://cmake.org/cmake/help/v3.16/manual/cmake-buildsystem.7.html#imported-targets [2] latest: https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#imported-targets
Error:
|
psaavedra
added a commit
to Igalia/meta-webkit
that referenced
this pull request
Sep 6, 2022
…FDO" error ... because target "PkgConfig::WpeFDO" is imported but not globally visible in cmake/FindWpeFDO.cmake. Notice that this issue is not reproducible in CMake v3.22 (ej. Kirkstone). CMake doc [1][2] says: "The scope of the definition of an IMPORTED target is the directory where it was defined. It may be accessed and used from subdirectories, but not from parent directories or sibling directories. The scope is similar to the scope of a cmake variable. It is also possible to define a GLOBAL IMPORTED target which is accessible globally in the buildsystem." [1] 3.16: https://cmake.org/cmake/help/v3.16/manual/cmake-buildsystem.7.html#imported-targets [2] latest: https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#imported-targets Upstream-Status: Submitted [Igalia/cog#487]
@aperezdc, I'm not sure how to proceed. The https://github.com/Igalia/cog/runs/8203858606?check_suite_focus=true blames against a changed not done in this patch. |
psaavedra
added a commit
to Igalia/meta-webkit
that referenced
this pull request
Sep 6, 2022
…FDO" error ... because target "PkgConfig::WpeFDO" is imported but not globally visible in cmake/FindWpeFDO.cmake. Notice that this issue is not reproducible in CMake v3.22 (ej. Kirkstone). CMake doc [1][2] says: "The scope of the definition of an IMPORTED target is the directory where it was defined. It may be accessed and used from subdirectories, but not from parent directories or sibling directories. The scope is similar to the scope of a cmake variable. It is also possible to define a GLOBAL IMPORTED target which is accessible globally in the buildsystem." [1] 3.16: https://cmake.org/cmake/help/v3.16/manual/cmake-buildsystem.7.html#imported-targets [2] latest: https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#imported-targets Upstream-Status: Submitted [Igalia/cog#487]
aperezdc
approved these changes
Sep 6, 2022
Good find, thanks @psaavedra! I'll merge this manually, the style checker is being silly. |
psaavedra
added a commit
to Igalia/meta-webkit
that referenced
this pull request
Sep 6, 2022
…FDO" error ... because target "PkgConfig::WpeFDO" is imported but not globally visible in cmake/FindWpeFDO.cmake. Notice that this issue is not reproducible in CMake v3.22 (ej. Kirkstone). CMake doc [1][2] says: "The scope of the definition of an IMPORTED target is the directory where it was defined. It may be accessed and used from subdirectories, but not from parent directories or sibling directories. The scope is similar to the scope of a cmake variable. It is also possible to define a GLOBAL IMPORTED target which is accessible globally in the buildsystem." [1] 3.16: https://cmake.org/cmake/help/v3.16/manual/cmake-buildsystem.7.html#imported-targets [2] latest: https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#imported-targets Upstream-Status: Submitted [Igalia/cog#487]
psaavedra
added a commit
to Igalia/meta-webkit
that referenced
this pull request
Sep 6, 2022
…FDO" error ... because target "PkgConfig::WpeFDO" is imported but not globally visible in cmake/FindWpeFDO.cmake. Notice that this issue is not reproducible in CMake v3.22 (ej. Kirkstone). CMake doc [1][2] says: "The scope of the definition of an IMPORTED target is the directory where it was defined. It may be accessed and used from subdirectories, but not from parent directories or sibling directories. The scope is similar to the scope of a cmake variable. It is also possible to define a GLOBAL IMPORTED target which is accessible globally in the buildsystem." [1] 3.16: https://cmake.org/cmake/help/v3.16/manual/cmake-buildsystem.7.html#imported-targets [2] latest: https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#imported-targets Upstream-Status: Submitted [Igalia/cog#487]
psaavedra
added a commit
to Igalia/meta-webkit
that referenced
this pull request
Sep 6, 2022
…FDO" error ... because target "PkgConfig::WpeFDO" is imported but not globally visible in cmake/FindWpeFDO.cmake. Notice that this issue is not reproducible in CMake v3.22 (ej. Kirkstone). CMake doc [1][2] says: "The scope of the definition of an IMPORTED target is the directory where it was defined. It may be accessed and used from subdirectories, but not from parent directories or sibling directories. The scope is similar to the scope of a cmake variable. It is also possible to define a GLOBAL IMPORTED target which is accessible globally in the buildsystem." [1] 3.16: https://cmake.org/cmake/help/v3.16/manual/cmake-buildsystem.7.html#imported-targets [2] latest: https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#imported-targets Upstream-Status: Submitted [Igalia/cog#487]
psaavedra
added a commit
to Igalia/meta-webkit
that referenced
this pull request
Sep 6, 2022
…FDO" error ... because target "PkgConfig::WpeFDO" is imported but not globally visible in cmake/FindWpeFDO.cmake. Notice that this issue is not reproducible in CMake v3.22 (ej. Kirkstone). CMake doc [1][2] says: "The scope of the definition of an IMPORTED target is the directory where it was defined. It may be accessed and used from subdirectories, but not from parent directories or sibling directories. The scope is similar to the scope of a cmake variable. It is also possible to define a GLOBAL IMPORTED target which is accessible globally in the buildsystem." [1] 3.16: https://cmake.org/cmake/help/v3.16/manual/cmake-buildsystem.7.html#imported-targets [2] latest: https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#imported-targets Upstream-Status: Submitted [Igalia/cog#487]
psaavedra
added a commit
to Igalia/meta-webkit
that referenced
this pull request
Sep 7, 2022
…FDO" error ... because target "PkgConfig::WpeFDO" is imported but not globally visible in cmake/FindWpeFDO.cmake. Notice that this issue is not reproducible in CMake v3.22 (ej. Kirkstone). CMake doc [1][2] says: "The scope of the definition of an IMPORTED target is the directory where it was defined. It may be accessed and used from subdirectories, but not from parent directories or sibling directories. The scope is similar to the scope of a cmake variable. It is also possible to define a GLOBAL IMPORTED target which is accessible globally in the buildsystem." [1] 3.16: https://cmake.org/cmake/help/v3.16/manual/cmake-buildsystem.7.html#imported-targets [2] latest: https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#imported-targets Upstream-Status: Submitted [Igalia/cog#487]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... because target "PkgConfig::WpeFDO" is imported but not globally visible in cmake/FindWpeFDO.cmake.
Notice that this issue is not reproducible in CMake v3.22.
CMake doc [1][2] says:
[1] 3.16: https://cmake.org/cmake/help/v3.16/manual/cmake-buildsystem.7.html#imported-targets
[2] latest: https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#imported-targets
Note: Target branch is cog-0.14 since there is not longer CMake rules in the master branch.