Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Fix building with WebKitGTK+ after CogShell introduction #54

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

aperezdc
Copy link
Member

Use cog_launcher_get_shell() + cog_shell_get_web_view() instead of the cog_launcher_get_web_view() function, which was removed.

Use cog_launcher_get_shell() + cog_shell_get_web_view() instead
of the cog_launcher_get_web_view() function, which was removed.
@aperezdc aperezdc added the bug Something isn't working label Aug 14, 2018
@aperezdc
Copy link
Member Author

P.S: This wouldn't have gone unnoticed if we had CI. Hopefully I'll have something in that department in the coming weeks 😉

Copy link
Contributor

@elima elima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@aperezdc aperezdc merged commit a9ac10e into master Aug 17, 2018
@aperezdc aperezdc deleted the fix-gtk-after-cog-shell branch August 17, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants