Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wl: Specify button modifier in listeners #689

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

matperc
Copy link
Contributor

@matperc matperc commented Jan 8, 2024

TODO:

  • Is it necessary to fix the button value passed through WPE? It doesn't seem to affect the result in my tests
  • Implement back and forward buttons (I don't have the hardware right now to test it). I can't test the extra buttons since they change the browser page (obviously...). So I'll just removed them. The behavior is the same as before for those buttons

Closes #688

@matperc matperc marked this pull request as ready for review January 21, 2024 09:19
@aperezdc aperezdc self-requested a review August 26, 2024 12:14
@aperezdc aperezdc added bug Something isn't working enhancement New feature or request labels Aug 26, 2024
Copy link
Member

@aperezdc aperezdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @matperc and apologies for the late review 🙏🏼

@aperezdc aperezdc merged commit 8610a20 into Igalia:master Aug 26, 2024
@aperezdc
Copy link
Member

Backported into the cog-0.18 branch as commit f2bbcbf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request merge:cog-0.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MouseEvent buttons property not set in wayland backend
2 participants