Add an option to control permission requests #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperezdc
requested changes
Mar 18, 2019
This adds the following API function: * cog_launcher_add_web_permissions_option_entries Currently only 2 values are accepted 'all' and 'none', by default no permissions are granted. Long term, we will be able to add a more complete synthax to let the user decide what to accept and what not.
aperezdc
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following API function:
Currently only 2 values are accepted 'all' and 'none', by default
no permissions are granted.
Long term, we will be able to add a more complete synthax to let the
user decide what to accept and what not.