Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize Libraries and add search UI in panels #881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reorganize Libraries and add search UI in panels #881

wants to merge 1 commit into from

Conversation

HollowMan6
Copy link
Collaborator

@HollowMan6 HollowMan6 commented Jul 30, 2023 •
edited
Loading

This PR is a part of the Library reorganizing Q2-Q3 Planning

Create a separate location in the UI for each functionality

  • (Library) Bookmarks/History
  • Downloads
  • Add-ons
  • Web Apps

Add launchers in the UI to open each of those locations

  • (Library) Bookmarks/History, Downloads and Web Apps from the tray
  • Add-ons from Hamburger Menu

Add Search UI in:

  • Bookmarks
  • History
  • Downloads
  • Web Apps

com igalia wolvic-20230902-193924

@HollowMan6 HollowMan6 changed the title Reorganize lib Reorganize Libraries Jul 30, 2023
@HollowMan6 HollowMan6 force-pushed the reorganize-lib branch 5 times, most recently from 84f56ab to 3437161 Compare August 1, 2023 15:19
@HollowMan6
Copy link
Collaborator Author

The search UI is also ready now. We now only search when the user explicitly types search (enter) on the keyboard. We of course prefer to show the result as the user inputs something, but due to the focus change during the list update, this is still buggy (making the keyboard hide accidentally), so I made the restriction.

@HollowMan6 HollowMan6 changed the title Reorganize Libraries Reorganize Libraries and Search UI Aug 1, 2023
@HollowMan6 HollowMan6 force-pushed the reorganize-lib branch 7 times, most recently from aec5f88 to 195a6c4 Compare August 6, 2023 20:22
@HollowMan6 HollowMan6 force-pushed the reorganize-lib branch 2 times, most recently from 75527fe to 0f5f4c0 Compare August 20, 2023 11:30
@HollowMan6
Copy link
Collaborator Author

HollowMan6 commented Aug 21, 2023 •
edited
Loading

@felipeerias Any suggestions on this PR as well as the next steps for the UI?

For the Q2-Q3 Planning, now we only have "New Tab page" and "Tabs" to be implemented.

  • For New Tab page, I'm not actually sure if we want to modify https://wolvic.com/en/start/ directly or if we want to implement it as some embedded web page. If it's the later, which means we are actually reverting this a little bit to 3119dbd , which I think is not a good idea.
  • I've been looking into the Tabs one and it's been progressing slowly at https://github.com/Igalia/wolvic/tree/new-tabs (very buggy at the moment, will need some addition work to get it fixed)

@HollowMan6 HollowMan6 force-pushed the reorganize-lib branch 4 times, most recently from 12afce9 to 651058c Compare September 5, 2023 16:01
HollowMan6 added a commit that referenced this pull request Sep 5, 2023
@HollowMan6
Stop having findInPage and Panel opened at same time
a23e2cf 
We shouldn't let user feel that we can search content
in the library page through findInPage. So we close
findInPage when we open the Library, and we close the
panel when we open findInPage in the hamburger menu.

We shall pay attention to this as well in
#881
once this is merged

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
@HollowMan6 HollowMan6 mentioned this pull request Sep 5, 2023
Merged
svillar pushed a commit that referenced this pull request Sep 6, 2023
@HollowMan6 @svillar
Stop having findInPage and Panel opened at same time
7049cbc 
We shouldn't let user feel that we can search content
in the library page through findInPage. So we close
findInPage when we open the Library, and we close the
panel when we open findInPage in the hamburger menu.

We shall pay attention to this as well in
#881
once this is merged

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
@HollowMan6 HollowMan6 force-pushed the reorganize-lib branch 3 times, most recently from 965acb4 to dec1020 Compare September 10, 2023 15:28
@HollowMan6 HollowMan6 force-pushed the reorganize-lib branch 2 times, most recently from 6bc3ddf to 5a1dc85 Compare September 25, 2023 23:12
@HollowMan6 HollowMan6 force-pushed the reorganize-lib branch 3 times, most recently from 57ef2bf to 28660eb Compare October 23, 2023 09:16
svillar
svillar requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both for the tremendous effort. I reviewed it all together as it was a single author so I'm aware that some of my comments maybe do not apply. Also I was reviewing it commit by commit (as it was rather large) so you'd notice that some of my comments were partially addressed in the latests commits.

app/src/common/shared/com/igalia/wolvic/ui/viewmodel/WindowViewModel.java Show resolved Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java Outdated Show resolved Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java Outdated Show resolved Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java Outdated Show resolved Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/Windows.java Outdated Show resolved Hide resolved
app/src/main/res/values/dimen.xml Outdated Show resolved Hide resolved
app/src/main/res/values/dimen.xml Show resolved Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java Show resolved Hide resolved
app/src/main/res/layout/tray.xml Show resolved Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/WindowWidget.java Show resolved Hide resolved
@HollowMan6 HollowMan6 changed the title Reorganize Libraries and Search UI Reorganize Libraries and add search UI in panels Nov 27, 2023
@HollowMan6 HollowMan6 force-pushed the reorganize-lib branch 2 times, most recently from b81382b to e986ed7 Compare November 27, 2023 17:56
@HollowMan6
Reorganize Libraries and add search UI in panels
b49f249 
Create a separate location in the UI for each functionality

- (Library) Bookmarks/History
- Downloads
- Add-ons
- Web Apps

Add launchers in the UI to open each of those locations

- (Library) Bookmarks/History, Downloads and Web Apps from the tray
- Add-ons from Hamburger Menu

Add Search UI in:

- Bookmarks
- History
- Downloads
- Web Apps

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
HollowMan6
HollowMan6 commented May 10, 2024
View reviewed changes
Copy link
Collaborator Author

@HollowMan6 HollowMan6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rebased the branch with the latest commits in main and it still LGTM without regression. Since I'm about to return the VR headset, feel free to take over this PR now as I have no more resources to continue working on this.

@svillar
Copy link
Member

svillar commented May 14, 2024

I have rebased the branch with the latest commits in main and it still LGTM without regression. Since I'm about to return the VR headset, feel free to take over this PR now as I have no more resources to continue working on this.

Great, many thanks for the hard work. Pretty busy ATM with the upcoming 1.6.1 and also new devices, but we'll definitely integrate all this later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeerias felipeerias Awaiting requested review from felipeerias

@svillar svillar Awaiting requested review from svillar

@javifernandez javifernandez Awaiting requested review from javifernandez

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HollowMan6 @svillar