Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In IE parent grid scrolls when using ctr + right navigation. #4488

Closed
MartinKamenov opened this issue Apr 8, 2019 · 0 comments · Fixed by #5308
Closed

In IE parent grid scrolls when using ctr + right navigation. #4488

MartinKamenov opened this issue Apr 8, 2019 · 0 comments · Fixed by #5308
Assignees
@mpavlinov @MayaKirova
Labels
browser: IE-11 Issues specific to the MS IE11 browser 🐛 bug Any issue that describes a bug grid: hierarchical-grid keyboard-navigation severity: low version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@MartinKamenov
Copy link
Contributor

Description

Currently when using ctr + right for navigating to the last cell parent grid scrolls and child grid flips on IE.

  • igniteui-angular version: 7.2.x
  • browser: IE

Steps to reproduce

  1. Open hierarchical grid dev sample on IE.
  2. Select the first cell of the first child grid.
  3. Use ctr + right for navigation.

Result

Child grid flips and parent grid scrolls down even though the cell is visible without scrolling.

Expected result

Grid should stay in same position without scrolling.

Attachments

KeyboardNavIE
@MartinKamenov MartinKamenov mentioned this issue Apr 8, 2019
Merged
14 tasks
@MartinKamenov MartinKamenov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Apr 10, 2019
MartinKamenov added a commit that referenced this issue Apr 10, 2019
@MartinKamenov
fix(navigation): Focusing on parent grid on keyboard navigation IE #4488
4115a6d
@MartinKamenov MartinKamenov mentioned this issue Apr 10, 2019
Merged
14 tasks
@mpavlinov mpavlinov assigned MayaKirova and unassigned MartinKamenov Jul 1, 2019
@mpavlinov mpavlinov added 🆕 status: new and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 4, 2019
MayaKirova pushed a commit that referenced this issue Jul 4, 2019
@MartinKamenov @MayaKirova
fix(navigation): Focusing on parent grid on keyboard navigation IE #4488
d146c51
@MayaKirova MayaKirova mentioned this issue Jul 4, 2019
Merged
14 tasks
MayaKirova pushed a commit that referenced this issue Jul 4, 2019
@MartinKamenov @MayaKirova
fix(navigation): Focusing on parent grid on keyboard navigation IE #4488
7673a49
@MayaKirova MayaKirova mentioned this issue Jul 4, 2019
Merged
14 tasks
MayaKirova pushed a commit that referenced this issue Jul 4, 2019
@MartinKamenov @MayaKirova
fix(navigation): Focusing on parent grid on keyboard navigation IE #4488
ef6aaa7
@MayaKirova MayaKirova mentioned this issue Jul 4, 2019
Merged
14 tasks
@MayaKirova MayaKirova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🆕 status: new labels Jul 4, 2019
ChronosSF pushed a commit that referenced this issue Jul 10, 2019
@MayaKirova @ChronosSF
Focusing on parent grid using keyboard navigation in IE. (#5307)
45571ff 
* fix(navigation): Focusing on parent grid on keyboard navigation IE #4488

* chore(navigation): Put focus element validation in hgrid service.

* chore(navigation): Added getFocusGrid function for in HGrid navigation service.

* chore(*): Applying review changes.

* chore(*): Fix merge issue.

* chore(*): Fix more merge issues.

* chore(*): Fixing review comments.

* chore(*): In case child grid last row is not visible in parent view port make sure parent grid is first scrolled so that child grid bottom is in view before attempting to focus last cell in child.

* chore(*): Make sure calculation are done based on root grid tbody.
ChronosSF pushed a commit that referenced this issue Jul 10, 2019
@MayaKirova @ChronosSF
Focusing on parent grid using keyboard navigation in IE. (#5308)
29e5e85 
* fix(navigation): Focusing on parent grid on keyboard navigation IE #4488

* chore(navigation): Put focus element validation in hgrid service.

* chore(navigation): Added getFocusGrid function for in HGrid navigation service.

* chore(*): Applying review changes.

* chore(*): Fix merge issue.

* chore(*): Fixing more merge issues.

* chore(*): Fixing more merge issues.

* chore(*): Fixing review comments.

* chore(*): In case child grid last row is not visible in parent view port make sure parent grid is first scrolled so that child grid bottom is in view before attempting to focus last cell in child.

* chore(*): Make sure calculation are done based on root grid tbody.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpavlinov mpavlinov

@MayaKirova MayaKirova

Labels
browser: IE-11 Issues specific to the MS IE11 browser 🐛 bug Any issue that describes a bug grid: hierarchical-grid keyboard-navigation severity: low version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Focusing on parent grid using keyboard navigation in IE. IgniteUI/igniteui-angular
3 participants
@mpavlinov @MayaKirova @MartinKamenov