Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using onGridCreated on a row island throws an error #6860

Closed
3phase opened this issue Mar 4, 2020 · 1 comment · Fixed by #7585
Closed

Using onGridCreated on a row island throws an error #6860

3phase opened this issue Mar 4, 2020 · 1 comment · Fixed by #7585
Assignees
@dkamburov @ChronosSF
Labels
🐛 bug Any issue that describes a bug grid: hierarchical-grid severity: low ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@3phase
Copy link
Contributor

3phase commented Mar 4, 2020 •
edited
Loading

Description

When the onGridCreated event is used for a given child row and when detectChanges is called on the event's grid, multiple errors are thrown (see attached image).

The most common usecase of onGridCreated concerns the load on demand feature, which suggests using an http request (or a similar task). The execution of that request may require some time and is going to be resolved in a different event loop. When the user decides not to use any requests (and promises), the event's grid seems to be not yet registered and one has to create a new macrotask by themselves, as for instance setTimeout, which works as a proper workaround of the issue.

The upmentioned behavior could be observed in the following sample:
https://stackblitz.com/edit/bug-igx-hierarchical-grid-shachm,
while the workaround with setTimeout is to be found here:
https://stackblitz.com/edit/bug-igx-hierarchical-grid-d1rxf9

Attachments

image
@github-actions
Copy link

github-actions bot commented May 8, 2020

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label May 8, 2020
@ChronosSF ChronosSF removed the status: inactive Used to stale issues and pull requests label May 18, 2020
@ChronosSF ChronosSF reopened this May 18, 2020
dkamburov added a commit that referenced this issue Jun 3, 2020
@dkamburov
fix(hgrid): Explicitly invoke detectChanges for the root grid #6860
55241b5
@dkamburov dkamburov added the 🛠️ status: in-development Issues and PRs with active development on them label Jun 3, 2020
@dkamburov dkamburov mentioned this issue Jun 4, 2020
Merged
14 tasks
dkamburov added a commit that referenced this issue Jun 4, 2020
@dkamburov
fix(hgrid): Expose onGridInitialized output #6860
f0a64c5
@MayaKirova MayaKirova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 8, 2020
kdinev added a commit that referenced this issue Jun 8, 2020
@kdinev
Merge pull request #7482 from IgniteUI/dkamburov/fix-6860
6299662 
 fix(hgrid): Expose onGridInitialized output #6860
This was referenced Jun 8, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkamburov dkamburov

@ChronosSF ChronosSF

Labels
🐛 bug Any issue that describes a bug grid: hierarchical-grid severity: low ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
4 participants
@dkamburov @ChronosSF @3phase @MayaKirova