Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(icon-service): cache svg icons as text #10202

Merged
merged 28 commits into from
Oct 11, 2021
Merged

refactor(icon-service): cache svg icons as text #10202

merged 28 commits into from
Oct 11, 2021

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Sep 27, 2021 •
edited
Loading

Closes #9190

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff requested a review from kdinev October 1, 2021 11:17
@simeonoff simeonoff marked this pull request as ready for review October 1, 2021 11:17
@simeonoff simeonoff requested a review from pmoleri October 6, 2021 11:14
kdinev
kdinev previously approved these changes Oct 6, 2021
View reviewed changes
@zdrawku
Copy link
Contributor

zdrawku commented Oct 7, 2021

Issue #9975 might be related

pmoleri
pmoleri approved these changes Oct 8, 2021
View reviewed changes
Copy link

@pmoleri pmoleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.
Does this need to be updating Changelog file?

pmoleri
pmoleri requested changes Oct 8, 2021
View reviewed changes
Copy link

@pmoleri pmoleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the status, please check the comment about display: block again, I think I mislead you into introducing a change that needs to be considered.
We use it as display: block, but it was our own global rule, it never came from ignite as I thought it was.

pmoleri
pmoleri previously approved these changes Oct 8, 2021
View reviewed changes
Copy link

@pmoleri pmoleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again. I think treating svg as block is correct and it's not introducing a change.

@simeonoff simeonoff changed the base branch from master to 12.2.x October 11, 2021 12:10
@simeonoff simeonoff dismissed pmoleri’s stale review October 11, 2021 12:10

The base branch was changed.

@simeonoff simeonoff changed the base branch from 12.2.x to master October 11, 2021 12:11
@simeonoff simeonoff merged commit 791b9a5 into master Oct 11, 2021
@simeonoff simeonoff deleted the simeonoff/icon-service branch October 11, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdinev kdinev kdinev left review comments

@pmoleri pmoleri pmoleri left review comments

Assignees

@pmoleri pmoleri

@hanastasov hanastasov

Labels
🖼️ icon version: 13.0.x ❌ status: awaiting-test PRs awaiting manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Svg icons don't work under shadow dom
5 participants
@simeonoff @zdrawku @kdinev @pmoleri @hanastasov