Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(IgxGridBaseDirective): Remove newline character when single cell value is copied #10381

Merged
merged 14 commits into from
Nov 5, 2021
Merged

feat(IgxGridBaseDirective): Remove newline character when single cell value is copied #10381

merged 14 commits into from
Nov 5, 2021

Conversation

katherinedragieva
Copy link
Contributor

@katherinedragieva katherinedragieva commented Oct 27, 2021 •
edited
Loading

Closes #10366

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@hanastasov hanastasov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 1, 2021
hanastasov
hanastasov requested changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@hanastasov hanastasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I turn off the copying header feature:

image

Then doing Paste does nothing - seems there is nothing in the clipboard.

@hanastasov hanastasov added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Nov 1, 2021
@katherinedragieva katherinedragieva added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 2, 2021
@hanastasov hanastasov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 3, 2021
@hanastasov hanastasov self-requested a review November 3, 2021 09:37
hanastasov
hanastasov requested changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@hanastasov hanastasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When copying single cell without the header, new line indicator is still there

@hanastasov hanastasov removed the 💥 status: in-test PRs currently being tested label Nov 3, 2021
@katherinedragieva katherinedragieva added the ❌ status: awaiting-test PRs awaiting manual verification label Nov 4, 2021
@hanastasov hanastasov removed the ❌ status: awaiting-test PRs awaiting manual verification label Nov 5, 2021
@hanastasov hanastasov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 5, 2021
@hanastasov hanastasov merged commit 400ba57 into master Nov 5, 2021
@hanastasov hanastasov deleted the kdragieva/single-cell-value-master branch November 5, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanastasov hanastasov hanastasov requested changes

Assignees
No one assigned
Labels
grid: copy-paste ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copying a cell value always includes a newline character
3 participants
@katherinedragieva @hanastasov @zdrawku