Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simple-combo): preserved the input value when selectionChanging is canceled - master #14395

Merged

Conversation

georgianastasov
Copy link
Contributor

Closes #14310

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@georgianastasov
Copy link
Contributor Author

🔧 Please note that at the moment this pull request will not function correctly and tests will fail. This is because the following pull requests for this issue must be merged first for compatibility:

This PR are crucial as it provide necessary changes that this PR relies on. Once it is merged, this PR can be re-evaluated for functionality and tests can be expected to pass as intended.

@georgianastasov georgianastasov changed the base branch from master to ganastasov/fix-14200-master June 19, 2024 12:45
@georgianastasov georgianastasov merged commit 4adf724 into ganastasov/fix-14200-master Jun 19, 2024
3 of 4 checks passed
@georgianastasov georgianastasov deleted the ganastasov/fix-14310-master branch June 19, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

igx-simple-combo: Input field does not display value when clearing is canceled in selectionChanging event
1 participant