Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): #3550 Fixed a bad validation check. #3605

Merged
merged 5 commits into from
Jan 16, 2019
Merged

Conversation

gedinakova
Copy link
Contributor

@gedinakova gedinakova commented Jan 14, 2019

Closes #3550
Fixed an issue with the initial validation fix.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@tachojelev tachojelev added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 15, 2019
@tachojelev tachojelev added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jan 15, 2019
@SAndreeva
Copy link
Contributor

@gedinakova, do we need a test?

@kdinev kdinev merged commit 29f35e0 into master Jan 16, 2019
@kdinev kdinev deleted the gedinakova/fix-3550 branch January 16, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
input version: 7.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting required IgxInput's value not via typing does not clear the invalid style.
5 participants