Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Services - Improve Exception Handling #8

Merged
merged 3 commits into from
Mar 10, 2024

Conversation

IlicMiljan
Copy link
Owner

@IlicMiljan IlicMiljan commented Mar 10, 2024

Description of Changes

This PR introduces significant improvements in exception handling across various library services. It implements custom exceptions, replacing generic exceptions for specific scenarios, such as invalid key length in ciphers.

Additionally, new tests have been added to ensure these custom exceptions function correctly under expected conditions.

How Has This Been Tested?

Tests for the new exceptions have been added to ensure that the custom exceptions are thrown as expected in defined scenarios.

Checklist

Please confirm the following:

  • I have tested my changes and corrected any errors.
  • I have documented my changes if necessary.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (b210580) to head (61a7882).

Additional details and impacted files
@@             Coverage Diff              @@
##               main       #8      +/-   ##
============================================
+ Coverage     95.55%   96.11%   +0.56%     
- Complexity       56       63       +7     
============================================
  Files            14       17       +3     
  Lines           180      206      +26     
============================================
+ Hits            172      198      +26     
  Misses            8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IlicMiljan IlicMiljan merged commit 70ead66 into main Mar 10, 2024
1 check passed
@IlicMiljan IlicMiljan deleted the improve-exception-handling branch March 10, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants