Add Support For Constant Basis In Splines #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldresser-ie
force-pushed
the
stepBasis
branch
from
ce76ca4 to
87f18dd
Compare
|
Note to self : don't merge this without retargeting it to RB-10.4. |
danieldresser-ie
force-pushed
the
stepBasis
branch
from
87f18dd to
1fc2ed5
Compare
|
Rebased onto RB-10.4 |
johnhaddon
reviewed
Sep 14, 2022
| @@ -650,7 +675,7 @@ IECore::DataPtr loadSpline( | |||
| size_t n = std::min( positions.size(), values.size() ); | |||
| for( size_t i = 0; i < n; ++i ) | |||
| { | |||
| if( unduplicateEndPoints && ( i == 0 || i == n - 1 ) ) | |||
| if( unduplicateEndPoints && ( i < unduplicateStartPoints || i >= n - unduplicateEndPoints ) ) | |||
There was a problem hiding this comment.
I think we can drop the unduplicateEndPoints && part?
danieldresser-ie
force-pushed
the
stepBasis
branch
from
1fc2ed5 to
bb0adc7
Compare
|
Addressed comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for "constant" basis for splines which creates stair step shapes. Turned up a few oddities in the solver and tests, but seems to be working fine now.