Fixed bug #4837: "Knobs not found" warning messages. #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug only appears when loading the LensDistort node UI for the first time with a file sequence specified. The cause was the early termination of the knob_changed() method before an update to the dynamic knobs was made. The fix also the code simpler to read.
… the bounding box despite the "black_outside" flag being turned on. An additional result of this fix is that the distorted image is no longer clipped slightly around the edges.
|
I have also fixed an additional issue where the black_outside flag wasn't being propagated correctly. |
andrewkaufman
added a commit
that referenced
this pull request
Oct 18, 2013
Fixed bug #4837: "Knobs not found" warning messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug only appears when loading the LensDistort node UI for the first time with a file sequence specified.
The cause was the early termination of the knob_changed() method before an update to the dynamic knobs was made. The fix also makes the code simpler to read.