Deleting normals on subdiv meshes converted from Houdini. #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subdivision meshes should not have normals, but they tend to get added accidentally when dealing with many meshes in a single SOP, as that would extend the normals attribute to all meshes. We force N to be excluded when converting subdiv (catmullClark) meshes.
johnhaddon
added a commit
that referenced
this pull request
Dec 3, 2013
Deleting normals on subdiv meshes converted from Houdini.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subdivision meshes should not have normals, but they tend to get added accidentally when dealing with many meshes in a single SOP, as that would extend the normals attribute to all meshes. We force N to be excluded when converting subdiv (catmullClark) meshes directly in the FromHoudiniPolygonsConverter. I considered making an optional parameter to keep normals in this case, but since most uses of the converters take default parameter values, I thought it wasn't necessarily worth while. I can add the option of there are strong opinions otherwise though.