added ToMayaCurvesConverter #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I mainly have nitpicky comments. Some of the copyright dates are wrong (should only be 2013 I presume). Also, can you add a doc comment on the class explaining that it only converts one curve out of the given primitive? Seeing as that's the case, maybe it would be better to match FromMayaCurveConverter with ToMayaCurveConverter (singular)? |
|
just renamed it ToMayaCurveConverter, and hopefully picked most of the nits.... |
johnhaddon
added a commit
that referenced
this pull request
Dec 20, 2013
added ToMayaCurvesConverter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of course if the CurvesPrimitive has more than one curve in it, this doesn't quite work... I've addressed this by adding a curveIndex parameter which defaults to zero, so if your input only has one curve it should just work, otherwise you can just manually loop over all the curves and convert each one.