Skip to content

Reducing memory footprint in StreamIndexedIO #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 6, 2014
Merged

Reducing memory footprint in StreamIndexedIO #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f96b245
Making StreamIndexedIO::Node work as MemberData, where it holds a poi…
Feb 22, 2014
5d82c15
Replacing the std::map to a sorted vector and sorting by the m_name f…
Feb 22, 2014
f96ed26
Changing StreamIndexedIO member from intrusive pointer to raw pointer.
Feb 22, 2014
0ceb10f
Fixing bug by checking if pointer is valid. Now all tests passing.
Feb 25, 2014
52a57b3
Adding SmallDataNode class (24 bytes long on 64bit machines) when the…
Feb 25, 2014
e955831
Updating comment.
Feb 25, 2014
9303ae5
Adding a compact Node class for representing non-expanded subIndexes:…
Feb 25, 2014
d6edca6
Bug fix: considering the new SubIndexNode a IndexedIO::Directory node…
Feb 26, 2014
9b3f82a
Being more frugal on the usage of the mutex that controls access to t…
Feb 27, 2014
96dae62
Removing conditional on delete.
Feb 28, 2014
46a19c6
Protecing member variables from the Node classes.
Mar 6, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/IECore/StreamIndexedIO.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,10 +255,11 @@ class StreamIndexedIO : public IndexedIO

StreamFile &streamFile() const;

NodePtr m_node;

private :

// \todo Either rename Node to MemberData or add it's member here and save one raw pointer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should definitely do this before merging - the whole Node vs NodeBase discrepancy is quite confusing.

Node *m_node;

void setRoot( const IndexedIO::EntryIDList &root );

};
Expand Down
Loading