Fixing default ObjectPool for larger sizes. #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, setting IECORE_OBJECTPOOL_MEMORY = 2048 or larger would overflow the lexical cast, and you'd end up with 18446744071562067968
|
The fix looks fine to me, but I'd assume that it's the multiply on the subsequent line that overflows rather than the lexical_cast? |
|
Yeah, you're right. My comment was unfair. |
ldmoser
added a commit
that referenced
this pull request
May 26, 2014
Fixing default ObjectPool for larger sizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, setting IECORE_OBJECTPOOL_MEMORY = 2048 or larger would overflow the lexical cast, and you'd end up with 18446744071562067968