Maya 2018 Support #832
Merged
Maya 2018 Support #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @mattigruener ! Can you make sure the Maya tests pass in all 3 of:
- Maya 2016.sp6
- Maya 2017.u5
- Maya 2018.4
You can run them (at IE) via:
scons APP=maya APP_VERSION=xxx testMaya
| MPlug interpolationPlug = fnMesh.findPlug( "ieMeshInterpolation", &st ); | ||
| if ( st ) | ||
| { | ||
| #if MAYA_API_VERSION >= 201800 |
There was a problem hiding this comment.
just a style thing, but we'd typically not indent the #if stuff, just the regular code
|
I ran the tests for those 3 versions and they all passed. @stefanfeess, these are the changes you'll need if you want to grab the 'official' fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into supporting 2018 and I believe these changes are all that's needed. I've tested with Maya 2018.4. Autodesk documents the changes in the Maya API here