Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return void according to the function signatures #592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return void according to the function signatures #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions imagick_class.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8267,7 +8267,7 @@ PHP_METHOD(Imagick, cropThumbnailImage)
}
/* }}} */

/* {{{ proto bool Imagick::resetIterator();
/* {{{ proto void Imagick::resetIterator();
Resets the iterator. Use it in conjunction with Imagick::nextImage() to iterate over all the images in a wand container.
*/
PHP_METHOD(Imagick, resetIterator)
Expand All @@ -8281,11 +8281,10 @@ PHP_METHOD(Imagick, resetIterator)

/* No magick is going to happen */
if (intern->magick_wand == NULL) {
RETURN_FALSE;
return;
}
intern->next_out_of_bound = 0;
MagickResetIterator(intern->magick_wand);
RETURN_TRUE;
}
/* }}} */

Expand Down Expand Up @@ -13155,7 +13154,7 @@ PHP_METHOD(Imagick, filter)
#endif //#if MagickLibVersion < 0x700
#endif // #ifdef IMAGICK_WITH_KERNEL

/* {{{ proto int Imagick::setAntiAlias(bool antialias)
/* {{{ proto void Imagick::setAntiAlias(bool antialias)
Set whether antialiasing should be used for operations. On by default.
*/
PHP_METHOD(Imagick, setAntialias)
Expand All @@ -13176,8 +13175,6 @@ PHP_METHOD(Imagick, setAntialias)
php_imagick_convert_imagick_exception(intern->magick_wand, "Unable to setAntiAlias" TSRMLS_CC);
return;
}

RETURN_TRUE;
}
/* }}} */

Expand Down Expand Up @@ -13258,8 +13255,6 @@ PHP_METHOD(Imagick, optimizeImageTransparency)
php_imagick_convert_imagick_exception(intern->magick_wand, "Optimize image transparency failed" TSRMLS_CC);
return;
}

RETURN_TRUE;
}
/* }}} */
#endif
Expand Down Expand Up @@ -13289,8 +13284,6 @@ PHP_METHOD(Imagick, autoGammaImage)
php_imagick_convert_imagick_exception(intern->magick_wand, "autoGammaImage" TSRMLS_CC);
return;
}

RETURN_TRUE;
}
/* }}} */
#endif //#if MagickLibVersion >= 0x660
Expand Down Expand Up @@ -13319,8 +13312,6 @@ PHP_METHOD(Imagick, autoOrient)
php_imagick_convert_imagick_exception(intern->magick_wand, "Unable autoOrient image" TSRMLS_CC);
return;
}

RETURN_TRUE;
}
/* }}} */
#endif // #if MagickLibVersion >= 0x692
Expand Down Expand Up @@ -13363,7 +13354,7 @@ PHP_METHOD(Imagick, compositeImageGravity)
#endif

#if MagickLibVersion >= 0x693
/* {{{ proto bool Imagick::localContrastImage(float radius, float strength)
/* {{{ proto void Imagick::localContrastImage(float radius, float strength)
Attempts to increase the appearance of large-scale light-dark transitions.
Local contrast enhancement works similarly to sharpening with an unsharp mask,
however the mask is instead created using an image with a greater blur distance.
Expand All @@ -13390,8 +13381,6 @@ PHP_METHOD(Imagick, localContrastImage)
php_imagick_convert_imagick_exception(intern->magick_wand, "Failed to localContrastImage" TSRMLS_CC);
return;
}

RETURN_TRUE;
}
/* }}} */
#endif // #if MagickLibVersion >= 0x693
Expand Down Expand Up @@ -13492,8 +13481,6 @@ PHP_METHOD(Imagick, setImageMask)
// You want ei->severity. ei->error_number
// the Go Imagick library does something like:
//return &MagickWandException{ExceptionType(C.int(et)), C.GoString(csdescription)}

RETURN_TRUE;
}
/* }}} */
#endif // IM_HAVE_IMAGICK_GETSETIMAGEMASK
Expand Down
1 change: 0 additions & 1 deletion imagickpixeliterator_class.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ PHP_METHOD(ImagickPixelIterator, resetIterator)
#if MagickLibVersion <= 0x628
internpix->iterator_position = 0;
#endif
RETURN_TRUE;
}
/* }}} */

Expand Down