small refinements and todo items added #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denbonte I tried to be careful and modify only the content cells, and did not re-run the cells to not modify the output, but it still didn't work... Perhaps we should just discuss tomorrow. Additional question that didn't make it to the PR: you use medpy (from what I see, only for calculating overlaps?). In general, I would prefer to stay with the minimum number of dependencies possible. Additional concern is that medpy has the GPL license. In our situation, we already rely on plastimatch that can be used to calculate overlap measures (see https://plastimatch.org/plastimatch.html#plastimatch-dice), so maybe we can get rid of medpy? |
fedorov
added a commit
that referenced
this pull request
Oct 1, 2023
Minor fixes to the Segmentation Primer Notebook
fedorov
pushed a commit
that referenced
this pull request
Oct 26, 2023
commit outputs only on push or when triggered by scheduler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.