This repository has been archived by the owner on Dec 29, 2021. It is now read-only.
As a Partner I want to edit map locations on a separate page #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weliveindetail
commented
Jun 26, 2020
weliveindetail
commented
Jun 26, 2020
weliveindetail
commented
Jun 26, 2020
weliveindetail
commented
Jun 26, 2020
c0un7-z3r0
previously requested changes
Jun 26, 2020
This reverts commit c57b950.
…view, not yet working)
…ew, not yet working)
… and report success after editing
weliveindetail
commented
Jun 30, 2020
c0un7-z3r0
reviewed
Jul 6, 2020
…nd instead implement DB access manually
… does return) I previously assumed React's `navigate` function to be a trap and not return. However, this is not the case. It does return and execute the remaining call stack..
weliveindetail
commented
Jul 8, 2020
|
Two open issues, for details please see my comments in the unresolved conversations: So far I didn't succeed to test the Sentry event capture as well as using react-hook-form on the edit page. Otherwise, I think this is ready now. |
This was referenced Jul 9, 2020
weliveindetail
dismissed
c0un7-z3r0’s stale review
I think, I addressed all your change requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step for ticket #90