Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponge 8 implementation #252

Closed
wants to merge 48 commits into from
Closed

Sponge 8 implementation #252

wants to merge 48 commits into from

Conversation

jpenilla
Copy link
Member

@jpenilla jpenilla commented Apr 26, 2021

Implements Cloud on Sponge 8.

This differs from the previous draft (#51) as it uses the Command.Raw API instead of registering commands directly with Brigadier.

@jpenilla jpenilla mentioned this pull request Apr 26, 2021
@jpenilla jpenilla added enhancement New feature or request implementation Platform implementations minecraft labels Apr 27, 2021
@jpenilla jpenilla force-pushed the feature/sponge branch 7 times, most recently from 561361c to 1135a3c Compare May 4, 2021 05:23
Base automatically changed from 1.5.0-dev to master July 5, 2021 09:56
@jpenilla jpenilla changed the base branch from master to 1.6.0-dev July 5, 2021 11:36
@jpenilla jpenilla force-pushed the feature/sponge branch 2 times, most recently from 331b1b8 to 69c2b85 Compare July 27, 2021 08:02
@jpenilla jpenilla changed the base branch from 1.6.0-dev to 1.7.0-dev December 2, 2021 10:56
@jpenilla
Copy link
Member Author

Needs to check for late command manager creation (causes late command registration checks to fail)

@jpenilla jpenilla force-pushed the feature/sponge branch 2 times, most recently from ff0a8c1 to cd4ab76 Compare January 13, 2022 23:02
@jpenilla jpenilla marked this pull request as ready for review January 13, 2022 23:07
@jpenilla jpenilla changed the base branch from 1.8.0-dev to 1.9.0-dev December 13, 2022 19:47
@github-actions
Copy link

Test Results

  52 files  ±0    52 suites  ±0   7s ⏱️ ±0s
227 tests ±0  227 ✔️ ±0  0 💤 ±0  0 ±0 
228 runs  ±0  228 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 96642d1. ± Comparison against base commit e3a8265.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implementation Platform implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants