Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate argument newBuilder methods and add builder methods to align with newer arguments #419

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

jpenilla
Copy link
Member

For a while now, new arguments have used builder instead of newBuilder for their static builder factories, this updates all existing types to use the new pattern for consistency.

@github-actions
Copy link

Test Results

  52 files  ±0    52 suites  ±0   8s ⏱️ -2s
226 tests ±0  226 ✔️ ±0  0 💤 ±0  0 ±0 
227 runs  ±0  227 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 9212bde. ± Comparison against base commit a53b321.

@jpenilla jpenilla added this to the 1.8.0 milestone Dec 12, 2022
@jpenilla jpenilla merged commit 1878964 into 1.8.0-dev Dec 13, 2022
@jpenilla jpenilla deleted the deprecate-newbuilder branch December 13, 2022 15:54
jpenilla added a commit that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants