-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add injection service support for suggestions methods. #440
add injection service support for suggestions methods. #440
Conversation
The only concern I have is that since tab-completes are running more than a regular command execution, this might create some performance issues. so I thought I might add a boolean parameter for @Suggestions annotations that refer to this feature to be enabled. What do you think? |
You can check if the method signature takes exactly one command context and one string in that order (and store the result in a field). If so the old logic can be used. |
done. i've also added tests similar to strict suggestions provider. can now be reviewed. |
… parser for annotations
I rebase the PR to 1.9.0-dev again. it's ready to merge. |
@jpenilla could you review the PR, please? |
This has been addressed in v2. |
closes #439