Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add injection service support for suggestions methods. #440

Closed
wants to merge 22 commits into from
Closed

add injection service support for suggestions methods. #440

wants to merge 22 commits into from

Conversation

portlek
Copy link
Contributor

@portlek portlek commented Apr 19, 2023

closes #439

@portlek
Copy link
Contributor Author

portlek commented Apr 19, 2023

The only concern I have is that since tab-completes are running more than a regular command execution, this might create some performance issues. so I thought I might add a boolean parameter for @Suggestions annotations that refer to this feature to be enabled. What do you think?

@portlek portlek changed the base branch from master to 1.9.0-dev April 19, 2023 15:34
@jpenilla
Copy link
Member

jpenilla commented Apr 19, 2023

The only concern I have is that since tab-completes are running more than a regular command execution, this might create some performance issues. so I thought I might add a boolean parameter for @Suggestions annotations that refer to this feature to be enabled. What do you think?

You can check if the method signature takes exactly one command context and one string in that order (and store the result in a field). If so the old logic can be used.

@portlek
Copy link
Contributor Author

portlek commented Apr 19, 2023

done. i've also added tests similar to strict suggestions provider. can now be reviewed.

@portlek
Copy link
Contributor Author

portlek commented Nov 24, 2023

I rebase the PR to 1.9.0-dev again. it's ready to merge.

@portlek
Copy link
Contributor Author

portlek commented Dec 7, 2023

@jpenilla could you review the PR, please?

@Citymonstret
Copy link
Member

This has been addressed in v2.

@portlek portlek deleted the feat/injection-for-suggestions branch January 15, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add InjectionService support for @Suggestions methods.
4 participants