Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default values to fail parsing #598

Merged
merged 5 commits into from
Feb 3, 2024

Conversation

jpenilla
Copy link
Member

Proof of concept for #597

@jpenilla jpenilla added enhancement New feature or request 2.0.0 labels Dec 27, 2023
@jpenilla jpenilla linked an issue Dec 27, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Dec 27, 2023

Test Results

 84 files  ±0   84 suites  ±0   13s ⏱️ ±0s
415 tests +1  415 ✅ +1  0 💤 ±0  0 ❌ ±0 
459 runs  +1  459 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 0e41602. ± Comparison against base commit 3d937b3.

♻️ This comment has been updated with latest results.

@jpenilla jpenilla force-pushed the feat/2.0.0/failable-dynamic-defaults branch 2 times, most recently from 83c993f to e6c3c27 Compare January 27, 2024 23:43
@jpenilla jpenilla force-pushed the feat/2.0.0/failable-dynamic-defaults branch from 1f7cb19 to a28c743 Compare February 1, 2024 02:00
@jpenilla jpenilla marked this pull request as ready for review February 1, 2024 21:41
@jpenilla jpenilla marked this pull request as draft February 1, 2024 21:41
@jpenilla jpenilla marked this pull request as ready for review February 1, 2024 22:12
@jpenilla jpenilla merged commit 3009430 into master Feb 3, 2024
5 checks passed
@jpenilla jpenilla deleted the feat/2.0.0/failable-dynamic-defaults branch February 3, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow dynamic default values to fail parsing
2 participants