feat: ldap auth & folder CRUD #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds LDAP authentication and folder CRUD operations to the SDK. The changes follow a builder pattern for better API consistency compared to existing secrets and universal auth implementations.
Key changes:
- Adds LDAP authentication login method to AuthClient
- Implements complete folder management with CRUD operations (create, read, update, delete, list)
- Introduces utility classes for object-to-map conversion and helper functions
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/infisical/sdk/util/ObjectToMapConverter.java | New utility for converting objects to string maps using reflection and annotations |
| src/main/java/com/infisical/sdk/util/Helper.java | Added null/empty string validation helper method |
| src/main/java/com/infisical/sdk/resources/FoldersClient.java | New client for folder CRUD operations |
| src/main/java/com/infisical/sdk/resources/AuthClient.java | Added LDAP authentication login method |
| src/main/java/com/infisical/sdk/models/*.java | Multiple new model classes for folder operations and LDAP auth |
| src/main/java/com/infisical/sdk/api/ApiClient.java | Fixed null pointer issue in query parameter handling |
| src/main/java/com/infisical/sdk/InfisicalSdk.java | Integrated FoldersClient into main SDK class |
| pom.xml | Added Jackson dependencies and updated Lombok version |
src/main/java/com/infisical/sdk/models/SingleFolderResponse.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds LDAP auth support and support for folder CRUD operations. All new functions follow the builder pattern unlike the secrets resource and Universal Auth login. We will add overloads in the future to move secrets and universal auth to use the builder pattern as well.