feat: type-safe conversion for line-protocol Addfield #43

[arukiidou]

• Closes Type-safe conversion for line-protocol Addfield #43
  • back to draft. in favor of feat: add structured query #45.

Proposed Changes

• Add line-protocol compliant wrapper
• Add generic type constraints
  • line-protocol type
    • Float
    • Integer
    • Uinteger
    • String
    • Bool
  • native go <> line-protocol shortcut
  • time.Time conversion
  • time.Duration - using fmt.Stringer

func (m *Point) AddFieldFromValue(k string, v lineprotocol.Value) *Point {}
func NewValueFromInt[I Integer](v I) lineprotocol.Value {}

Usage

func example() {
	p := NewPoint("measurement", map[string]string{}, map[string]interface{}{"measurement": "air"}, time.Now())
        // unsupported type.
	p.AddFieldFromValue("✅ Compile error.", cmplx.Inf())
        // supported type.
	p.AddFieldFromValue("✅ This is safe.", NewValueFromInt(255))
}

Checklist

• CHANGELOG.md updated
• Rebased/mergeable
• A test has been added if appropriate
• Tests pass
• Commit messages are conventional
• Sign CLA (if not already signed)

[bednar]

@arukiidou, thank you for using our client and for your PR. We're excited to review it once it's ready.

[arukiidou]

ready for review. 👍
rebased behind of v0.3.0

[arukiidou]

fixed,sorry🙏

[bednar]

Add Float as a prefix to docs:

Suggested change

	// [Float] is IEEE-754 64-bit floating-point numbers. Default numerical type. InfluxDB supports scientific notation in float field values.
	// Float [Float] is IEEE-754 64-bit floating-point numbers. Default numerical type. InfluxDB supports scientific notation in float field values.

[arukiidou]

fixed.

[bednar]

Add Integer as a prefix to docs:

Suggested change

	// [Integer] is signed 64-bit integers.
	// Integer [Integer] is signed 64-bit integers.

[arukiidou]

fixed.

[bednar]

Add UInteger as a prefix to docs:

Suggested change

	// [UInteger] is unsigned 64-bit integers.
	// UInteger [UInteger] is unsigned 64-bit integers.

[arukiidou]

fixed.

[bednar]

Add String as a prefix to docs:

Suggested change

	// [String] is plain text string. Length limit 64KB.
	// String [String] is plain text string. Length limit 64KB.

[arukiidou]

fixed.

[bednar]

Add Boolean as a prefix to docs:

Suggested change

	// [Boolean] is true or false values.
	// Boolean [Boolean] is true or false values.

[arukiidou]

fixed.

[bednar]

I have a question regarding the use of lineprotocol.Value. Is its usage necessary? What do you think about adding something like AddStringField(k string, v string) to Point?

func (m *Point) AddStringField(k string, v string) *Point {
	m.AddField(k, v)
	return m
}

[arukiidou]

I have a question regarding the use of lineprotocol.Value. Is its usage necessary? What do you think about adding something like AddStringField(k string, v string) to Point?

func (m *Point) AddStringField(k string, v string) *Point {
	m.AddField(k, v)
	return m
}

• Oh, I prefer AddStringField better.

[bednar]

We aim to synchronize the API across our v3 clients — js, go, java, and c#. We've already updated the API in both the c# and js clients. For more information, see:

JS Client PR #89
JS Client PR #89 File Diff
C# Client PR #52
C# Client PR #52 File Diff

[bednar]

@arukiidou thanks again for your PR. Can you please align your code with upcoming changes for structured query - #45?

[arukiidou]

@arukiidou thanks again for your PR. Can you please align your code with upcoming changes for structured query - #45?

Yes, I will do so. It may take some time.

[arukiidou]

@bednar

• After a little consideration, I seem to be mostly satisfied with feat: add structured query #45. I don't see anything to add, thanks!