Skip to content

Conversation

NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Aug 15, 2025

Closes #

Proposed Changes

  • Backlog link
  • Add support for arm64 in CircleCI.
  • Looks like CircleCI does not have support for arm32v7 architecture.
  • Should we add support for Windows?
  • Modify the upload Codecov steps to accommodate arm64, but the links they use on their page are incorrect, so I have to create this Issue

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 added this to the 1.4.0 milestone Aug 15, 2025
@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Aug 15, 2025
@NguyenHoangSon96 NguyenHoangSon96 marked this pull request as ready for review August 15, 2025 06:33
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.07%. Comparing base (36574b9) to head (d4fc602).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files          20       20           
  Lines        1207     1207           
  Branches      188      188           
=======================================
  Hits         1051     1051           
  Misses         76       76           
  Partials       80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool work. 👍 I have one small request for the update to CHANEGLOG.md. Also, IMHO, it would be nice if commit messages were more informative than just wip. A slightly more informative message can always include (WIP).

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚴 🏁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants