-
Notifications
You must be signed in to change notification settings - Fork 4
feat: support arm64 circleci #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 20 20
Lines 1207 1207
Branches 188 188
=======================================
Hits 1051 1051
Misses 76 76
Partials 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool work. 👍 I have one small request for the update to CHANEGLOG.md
. Also, IMHO, it would be nice if commit messages were more informative than just wip
. A slightly more informative message can always include (WIP)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚴 🏁
Closes #
Proposed Changes
Checklist