Skip to content

Scoped Warnings and Suggestions

Latest

Choose a tag to compare

@Phillita Phillita released this 11 Sep 17:56
· 29 commits to comments-for-changed-lines-only since this release

The original gem wouldn't scope down on the suggestions/comments made the the pull request.

As an example, the frozen_string_literal comment has a warning that spans the entire file. If you haven't changed any of the code near the warning, you'd receive a comment on the nearest changed line of code. This ends up being confusing.

There are new options in the pronto config:

  • only_patched_lines:
    • enabled: true or false
    • range: N (number of lines your like to include warnings for near a changed line)

Furthermore, if a comment is being made for a line outside the changed lines, the comment will say which line the warning is connected to.