Feat/sync dev with master after v1.11.2 #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughAdds v1 deprecations, introduces a new Composer v2 message (MsgCancelPostOnlyMode), updates proto pins and regenerated protobufs (auction, exchange v2, megavault, downtimedetector), adds orderbook V2 height fields and optional depth in AsyncClient, updates tokens URL paths, adjusts examples’ oracle_scale_factor, and refreshes OFAC entries and tests. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant App
participant AsyncClient(v1)
participant IndexerClient
rect rgba(230,240,255,0.5)
note over AsyncClient(v1): New optional depth parameter
App->>AsyncClient(v1): fetch_spot_orderbook_v2(market_id, depth?)
AsyncClient(v1)->>IndexerClient: fetch_spot_orderbook_v2(market_id, depth or 0)
IndexerClient-->>AsyncClient(v1): OrderbookV2{bids, asks, height}
AsyncClient(v1)-->>App: Dict payload (includes height)
end
note over App,AsyncClient(v1): Instantiation emits DeprecationWarning (use async_client_v2)
sequenceDiagram
autonumber
participant App
participant ComposerV2
participant MsgService(gRPC)
participant Chain
rect rgba(240,255,240,0.5)
note over ComposerV2: New message constructor
App->>ComposerV2: msg_cancel_post_only_mode(sender)
ComposerV2-->>App: MsgCancelPostOnlyMode{sender}
App->>MsgService(gRPC): CancelPostOnlyMode(msg)
MsgService(gRPC)->>Chain: Apply cancel post-only mode
Chain-->>MsgService(gRPC): MsgCancelPostOnlyModeResponse
MsgService(gRPC)-->>App: Response
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (38)
Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the dev branch with master after the v1.11.2 release, bringing in new features and updates including new protobuf definitions, test coverage improvements, and version updates.
- Added new downtimedetector module with protobuf definitions and query interfaces
- Enhanced MegaVault RPC with additional endpoints for user management and analytics
- Updated multiple protobuf definitions to include new fields and parameters
- Added comprehensive test coverage for deprecation warnings and new functionality
Reviewed Changes
Copilot reviewed 40 out of 41 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Version bump to 1.12.0-rc1 |
| tests/ | Enhanced test coverage with new test cases for composer, async client deprecation, and updated API responses |
| pyinjective/proto/ | Updated protobuf definitions with new downtimedetector module, enhanced MegaVault RPC, and additional fields in exchange and auction modules |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aarmoa
force-pushed
the
feat/sync_dev_with_master_after_v1_11_2
branch
from
810d121 to
0c7e085
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch withmasterafter v1.11.2 releaseSummary by CodeRabbit