Table Alignment #136
Merged
Table Alignment #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmicHorrorDev
approved these changes
May 31, 2023
nicoburns
reviewed
Jun 1, 2023
Comment on lines
+332
to
+342
| let align = tag | ||
| .attrs | ||
| .iter() | ||
| .find(|attr| attr.name.local == local_name!("align")) | ||
| .map(|attr| match attr.value.to_string().as_str() { | ||
| "left" => Some(Align::Left), | ||
| "center" => Some(Align::Center), | ||
| "right" => Some(Align::Right), | ||
| _ => None, | ||
| }) | ||
| .unwrap_or_default(); |
There was a problem hiding this comment.
I see this bit is repeated. Maybe it would make sense to make it a method on tag or tag.attrs?
There was a problem hiding this comment.
I was planning on refactoring things in a followup PR to use an AttrIter iterator since there's a lot of near duplicated code for attribute parsing scattered around the interpreter
CosmicHorrorDev
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds table item horizontal alignment as shown below:
Looks like wrapping is still occurring in some weird places, might just be some f32 nonsense with the bounds changing slightly between rendering and layingout