Add tests for elements nested in a list item #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmicHorrorDev
added a commit
to CosmicHorrorDev/inlyne
that referenced
this pull request
Dec 2, 2023
CosmicHorrorDev
added a commit
that referenced
this pull request
Dec 2, 2023
* Add tests for elements nested in a list item (#176) * Backport fix for element nested in numbered list * Fix list prefix for footnotes * Try to get link anchor before using open to open it --------- Co-authored-by: Lucas Timmins <timmins.s.lucas@gmail.com> --------- Co-authored-by: Lucas Timmins <timmins.s.lucas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adds tests to cover the case described in #174. This will be accompanied by a backport to fix this behavior on the v0.3 release series in the next few days
Notably also worth mentioning that this behavior isn't entirely correct since the element nested within the list item should be indented further to indicate that it is part of the list item. I opened #175 to talk about how the interpreter can be refactored to better handle this kind of stuff in the future