Aimless test cleanup #189
Merged
Aimless test cleanup #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit is pretty independent
The improvements to failure detection in interpreter tests all revolve around trying to pick up on some internal task dying instead of just hanging forever. Since the interpreter and image fetching/decoding is all run in separate threads from the test any panic in those threads cause the test to hang. The thread panicking will still get captured and printed which is nice for easily debugging failures. All we needed to do was have conditions in place, so that the main test thread knows when to die appropriately
The other commit was just moving the existing YAML frontmatter test to join the other interpreter tests since it tests through even more code for free1
Footnotes
well... more or less ↩