fix(text): fix substract with overflow panic #217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197
This change avoids the panic, visually the behavior is the same.
However I'm not sure this is correct, because it means sometimes it won't be subtracted (and we get a wrong index?).
I don't get why we would need to subtract one to the index of the glyph under the cursor only if the cursor is associated with the previous frame. Also removing this
if Affinity::Before
altogether doesn't seem to change anything ...Have I misunderstood something in my reasoning?