Make underlines and strikethroughs respect align #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmicHorrorDev
added
C-bug
CosmicHorrorDev
commented
Feb 1, 2024
Valentin271
reviewed
Feb 1, 2024
There was a problem hiding this comment.
there's a lot of messy code in there to begin with
Yep felt that too.
This does feel a bit hacky to me too. Ideally render_lines would take a CachedTextArea or similar and not every detail about it.
But still this is way better than what I was trying to do on my fork.
Good point! Done and done |
CosmicHorrorDev
added
the
C-unreleased-regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #141
@Valentin271 I got a better idea of the underline code after working on #225. The fix feels hacky, but I'm not really familiar with the renderer and there's a lot of messy code in there to begin with 🤷
From what I can gather
leftgets set to the x coord of the text area including theAlignDemo
(Includes the use of
--page-widthto check that too)underline_align.mp4