COMP: Add includes for uint32_t in wrapping #3736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Dekker
reviewed
Nov 13, 2022
Comment on lines
32
to
+35
| #include "itkObjectFactory.h" | ||
| #include "itkNumericTraits.h" | ||
| #include "itkThreadSupport.h" | ||
| #include "itkIntTypes.h" |
There was a problem hiding this comment.
No problem, but I did notice that "itkObjectFactory.h" already indirectly includes "itkIntTypes.h", via itkObjectFactoryBase.h and then via itkCommonEnums.h:
While your proposed #include "itkIntTypes.h" is fine to me, I wonder if it has any effect.
There was a problem hiding this comment.
Yes, this seems to be a compiler issue. It addresses issues reported in #3506
thewtex
force-pushed
the
progress-int-types.h
branch
from
4103cdf to
fc1f6cc
Compare
thewtex
changed the title
N-Dekker
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Thanks Matt. While I understand that the aim is to fix issue #3506, it is also in accordance with the "Include what you use" strategy 😃 https://include-what-you-use.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.